Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation covering usage of the test-proxy config feature #6213

Merged
merged 5 commits into from
May 23, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented May 20, 2023

@samvaity for FYI, totally missed doing so with the original PR.

@scbedd scbedd requested a review from mikeharder as a code owner May 20, 2023 00:35
@scbedd scbedd self-assigned this May 22, 2023
- Invoke a CLI Tool to interact with recordings in an external store. ("push", "restore", "reset", "config")

Usage:
Azure.Sdk.Tools.TestProxy [command] [options]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be test-proxy assuming most are encouraged to use the standalone executable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but if you have this installed standalone or via dotnet tool won't test-proxy --help print out Azure.Sdk.Tools.TestProxy as the example command with this change?

Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff, but LGTM overall

@scbedd scbedd merged commit fcfad5d into Azure:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants