Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ubuntu 18.04 to 2X.04 ; update MMSUbuntu2X.04 to ubuntu-2X.04 #6004

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Update Ubuntu 18.04 to 2X.04 ; update MMSUbuntu2X.04 to ubuntu-2X.04 #6004

merged 4 commits into from
Apr 20, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Apr 19, 2023 •
edited
Loading

Update the used Ubuntu images per

I always updated the images to 20.04. The only places where I change 18 to 22 (instead of 20) is only to fix the fact the image was already on 22 but the related/surrounding symbols in the code weren't updated from 18 to 22.

Also update the obsolete MMSUbuntu2X.04 image names to ubuntu-2X.04.

Cannot update vmImage: MMSUbuntu22.04 in sdk-testgen/ci.yml
due to a test failure

Follow-up PRs

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Apr 19, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Apr 19, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team April 19, 2023 05:23
@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review April 19, 2023 05:25
@konrad-jamrozik konrad-jamrozik linked an issue Apr 19, 2023 that may be closed by this pull request
Migrate all pipelines off Ubuntu 18.04 by 4/1/2023 #5472
Closed
@konrad-jamrozik konrad-jamrozik changed the title Migrate Ubuntu 18.04 to 20.04 or 22.04, as appropriate Update Ubuntu 18.04 to 20.04 or 22.04, as appropriate; update MMSUbuntu22.04 to ubuntu-22.04 Apr 19, 2023
@konrad-jamrozik konrad-jamrozik changed the title Update Ubuntu 18.04 to 20.04 or 22.04, as appropriate; update MMSUbuntu22.04 to ubuntu-22.04 Update Ubuntu 18.04 to 2X.04 ; update MMSUbuntu2X.04 to ubuntu-2X.04 Apr 19, 2023
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member

benbp commented Apr 19, 2023

FYI @danieljurek the C++ binary sizes script will probably need to be extended/updated.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Apr 20, 2023 •
edited
Loading

I believe this PR is failing on tools - sdk-testgen - ci because the manual approval of release failed. It appears to ask me for that approval because it thinks it is a manual build (see Build.Reason here) and so it requires approval. I think this happened because I first scheduled this build by hand from my experimental branch, then rebased this PR branch onto it.

I think clicking Rerun failed jobs doesn't help here (I tried) because the job should not be there in the first place. If I rerun, I would have to approve, but I don't want to release anything.

So the problem is I am stuck with the added tools - sdk-testgen - ci (Release Package Approve) check which shouldn't be there in the first place, but is due to the initial Manual build.

Hence I must do /check-enforcer override to circumvent this problem.

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 80de661 into main Apr 20, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/ubuntu20 branch April 20, 2023 05:26
@Azure Azure deleted a comment from azure-pipelines bot Apr 20, 2023
@Azure Azure deleted a comment from azure-pipelines bot Apr 20, 2023
@Azure Azure deleted a comment from azure-pipelines bot Apr 20, 2023
@azure-sdk azure-sdk mentioned this pull request Apr 20, 2023
Merged
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Apr 20, 2023 •
edited
Loading

I overrode check-enforcer and merged for reasons explained in this comment, but I forgot I have to do the sync PRs. I am going to do it by hand using the build for this PR.

This was referenced Apr 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@konrad-jamrozik konrad-jamrozik mentioned this pull request Apr 20, 2023
Merged
@konrad-jamrozik
Copy link
Contributor Author

FYI @danieljurek Daniel Jurek FTE the C++ binary sizes script will probably need to be extended/updated.

@danieljurek @benbp

@konrad-jamrozik konrad-jamrozik mentioned this pull request Apr 20, 2023
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Apr 20, 2023
@azure-sdk
Sync eng/common directory with azure-sdk-tools for PR 6004 (#25598)
cb1bf97 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#6004 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Konrad Jamrozik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd left review comments

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@raych1 raych1 Awaiting requested review from raych1

@tadelesh tadelesh Awaiting requested review from tadelesh

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@maririos maririos Awaiting requested review from maririos

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate all pipelines off Ubuntu 18.04 by 4/1/2023
5 participants
@konrad-jamrozik @azure-sdk @benbp @mikeharder @scbedd