Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullReferenceException happening in ApiPath #5914

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

AaronPatterson
Copy link
Contributor

Ensure ApiPath does not get a NullReferenceExcepton when copying common parameters to operation method parameters.

Previously, when the operation method does not have any parameters a NullRefferenceException occurs when attempting to copy the common parameters to the operation method.

I encountered this when working on DevCenter RP and it looks like others have hit this issue as well: #5810

…on parameters to operation method parameters.

Previously, when the operation method does not have any parameters a null refference exception occurs when attempting to copy the common parameters to the operation metod.
@AaronPatterson AaronPatterson requested a review from a team as a code owner April 4, 2023 21:41
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this.parameters are the parameters declared just under "paths" in swagger, which it seems is the case by what I see here, this LGTM.

@AaronPatterson
Copy link
Contributor Author

Assuming this.parameters are the parameters declared just under "paths" in swagger, which it seems is the case by what I see here, this LGTM.

@heaths You are correct. this.parameters are the ones declared under the path.

@heaths heaths merged commit aef61a7 into Azure:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants