Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak to InitialIssueTriage and PullRequestTriage rules #5830

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

JimSuplizio
Copy link
Member

@JimSuplizio JimSuplizio commented Mar 27, 2023

There are several changes here:

  1. The InitialIssueTriage interim rule wasn't initially set to add the customer-reported and question labels. When looking at this @jsquire and I determined that the PullRequestTriage rule also needed to be updated.
  2. The Author Feedback Needed and Author Feedback rules, in the README were swapped in which one should add the comment which meant the rules also had to be updated. The README and rules function comments reflect this.
  3. The way Actions updated an issue or pull_request had to be changed. The short version is that the IssueUpdate can't really be used for Actions. This was causing things that the user did (updating labels, or changing things like the title and description) while the actions were being processed, to get reverted or, in some cases, completely overwritten. For labels, the IssueUpdate is a complete replace. Adding/Removing labels is now done through Octokit's IssueLabelsClient which is additive when adding labels. The only thing the IssueUpdate is used for, in Actions, is to set the state. Everything else is nulled out to prevent it updating. This fixes: Actions timing: Changes made by the user, while an action was processing and revert those changes #5835

@JimSuplizio JimSuplizio added Central-EngSys This issue is owned by the Engineering System team. GitHub Event Processor Anything related to the GitHub Event Processor labels Mar 27, 2023
@JimSuplizio JimSuplizio requested a review from a team as a code owner March 27, 2023 18:46
@JimSuplizio JimSuplizio self-assigned this Mar 27, 2023
@jsquire jsquire changed the title Tweak to InitialIssueTriage and PullRequestTriage rules Tweak to InitialIssueTriage and PullRequestTriage rules [Look] Mar 27, 2023
@jsquire jsquire changed the title Tweak to InitialIssueTriage and PullRequestTriage rules [Look] Tweak to InitialIssueTriage and PullRequestTriage rules Mar 27, 2023
@JimSuplizio JimSuplizio requested a review from jsquire March 28, 2023 20:41
@JimSuplizio JimSuplizio merged commit d386b5b into Azure:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. GitHub Event Processor Anything related to the GitHub Event Processor
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Actions timing: Changes made by the user, while an action was processing and revert those changes
2 participants