Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Proxy] Update recording asset transition script links #5762

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[Test Proxy] Update recording asset transition script links #5762

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a93e576
Update transition script links
mccoyp Mar 21, 2023
a555c78
Absolute links
mccoyp Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/test-proxy/documentation/asset-sync/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ First, ensure that your language-specific "shim" supports the automatic addition
- [PR Enabling in JS](https://github.com/Azure/azure-sdk-for-js/pull/23405)
- [PR Enabling in Go](https://github.com/Azure/azure-sdk-for-go/pull/19322)

Use [the transition script](../../scripts/transition-scripts/generate-assets-json.ps1) and follow the [readme](../../scripts/transition-scripts/README.md)!
Use [the transition script](../../../../eng/common/testproxy/transition-scripts/generate-assets-json.ps1) and follow the [readme](../../../../eng/common/testproxy/transition-scripts/README.md)!
scbedd marked this conversation as resolved.
Show resolved Hide resolved

In summary, once an assets.json is present, the shim _must_ be updated to **actually send** a reference to that assets.json inside the `record/start` or `playback/start` requests!

Expand Down