Add retry on specific git output #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
approved these changes
Mar 21, 2023
benbp
reviewed
Mar 21, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitProcessHandler.cs
Outdated
Show resolved
Hide resolved
benbp
reviewed
Mar 21, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitProcessHandler.cs
Outdated
Show resolved
Hide resolved
… when IsRetriableGitError is definitely the abstraction I needed to keep it simple
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scbedd
commented
Mar 22, 2023
| StdOut = stdOut, | ||
| Arguments = arguments | ||
| }; | ||
| attempts++; |
There was a problem hiding this comment.
for @benbp
enter loop, attempts = 1
invoke command, continueToAttempt = true
attempts = 2
delay 4 seconds because continueToAttempt = true
invoke command, continueToAttempts = true
attempts = 3
delay 6 seconds because continueToAttempt = true
invoke command, continueToAttempts = true
attempts = 4
we do not delay before exiting the loop, because 4 is not < max retry count and we won't be retrying anyway
For a grand total of 3 attempts, 2 retries. I'm good with this to start.
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #5660
Given the fact that we're shelling out and the exit code isn't different for every error, this looks like the way to go.