Improve status command output and improve error handling #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move schema into the tool folder - Greatly improve status command output - Fix exception handling in Key Vault stores
benbp
reviewed
Mar 13, 2023
tools/secret-rotation/Azure.Sdk.Tools.SecretRotation.Cli/Commands/StatusCommand.cs
Show resolved
Hide resolved
benbp
reviewed
Mar 13, 2023
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/azure/azure-sdk-tools/main/schemas/secretrotation/1.0.0/schema.json", | |||
| "$schema": "https://raw.githubusercontent.com/azure/azure-sdk-tools/main/tools/secret-rotation/schema/1.0.0/plan.json", | |||
There was a problem hiding this comment.
Is this the new desired pattern for schemas?
There was a problem hiding this comment.
Moving the schema to the tool folder was requested.
There was a problem hiding this comment.
Yes I wanted to keep the root of the tools repo clean and keep these scoped under the tool that uses them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move schema into the tool folder
Greatly improve status command output
Fix exception handling in Key Vault stores