Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move /web/pixel-server/ to /tools/pixel-server/ #5624

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Move /web/pixel-server/ to /tools/pixel-server/ #5624

merged 1 commit into from
Mar 6, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Mar 4, 2023 •
edited
Loading

Contributes to:

There appears to be no CI pipeline for the moved pixel-server. It appears to be still in use because the Application Insights intance logs mentioned in web/pixel-server/PixelServer/PixelServer.csproj have events coming in, per this query:

customEvents
| project name, operation_Name, timestamp, customDimensions.visitor_path
| where name == "PixelImpression" and timestamp >= ago(90d)
| sort by timestamp

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Mar 4, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Mar 4, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team March 4, 2023 20:52
@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review March 4, 2023 20:59
@konrad-jamrozik konrad-jamrozik changed the title Move pixel-server /web/pixel-server/ -> /tools/pixel-server/ Mar 4, 2023
@konrad-jamrozik konrad-jamrozik changed the title /web/pixel-server/ -> /tools/pixel-server/ /web/pixel-server/ → /tools/pixel-server/ Mar 4, 2023
scbedd
scbedd approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely old, but we run it to maintain the image servicing.

Filed #5629.

Approving this move.

@konrad-jamrozik konrad-jamrozik mentioned this pull request Mar 6, 2023
Open
@konrad-jamrozik konrad-jamrozik merged commit 83e289a into main Mar 6, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/move_web branch March 6, 2023 20:24
@konrad-jamrozik konrad-jamrozik changed the title /web/pixel-server/ → /tools/pixel-server/ Move /web/pixel-server/ to /tools/pixel-server/ Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konrad-jamrozik @scbedd