Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/.azure-pipelines/warden.yml → /eng/pipelines/doc-warden.yml #5617

Merged
merged 3 commits into from
Mar 7, 2023
Merged

/.azure-pipelines/warden.yml → /eng/pipelines/doc-warden.yml #5617

merged 3 commits into from
Mar 7, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Mar 4, 2023 •
edited
Loading

Contributes to:

Once this PR is merged, I will update the relevant pipeline to point to the new location of its definition file:
https://dev.azure.com/azure-sdk/internal/_build?definitionId=106

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Mar 4, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Mar 4, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team March 4, 2023 19:28
@konrad-jamrozik konrad-jamrozik changed the title Move warden.yml .azure-pipelines/warden.yml → eng/pipelines/doc-warden.yml Mar 4, 2023
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Mar 4, 2023 •
edited
Loading

@weshaggard the warden pipeline has all its triggers disabled via ADO UI and last run was in Dec 9, 2021, over 14 months ago. There also doesn't seem to be much activity in the packages/python-packages/doc-warden.

@scbedd @heaths @chidozieononiwu do you folks know if doc warden is still in use? I guess the pipeline is not in use recently as there weren't any code changes, but the package is in fact being used?

@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review March 4, 2023 19:41
@konrad-jamrozik konrad-jamrozik changed the title .azure-pipelines/warden.yml → eng/pipelines/doc-warden.yml /.azure-pipelines/warden.yml → /eng/pipelines/doc-warden.yml Mar 4, 2023
@heaths
Copy link
Member

heaths commented Mar 6, 2023

I didn't realize it wasn't running, but I don't know why it was turned off. I know it found some valid issues.

weshaggard
weshaggard approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be sure to update the pipeline to point to the new location.

@weshaggard
Copy link
Member

@konrad-jamrozik it is still in use for most of our language repos today. We have plans to retire it and move to a more generic MD linter tool in the future but that work is still on the backlog. See #1896

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 6e7621a into main Mar 7, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/move_warden.yml branch March 7, 2023 00:06
@konrad-jamrozik
Copy link
Contributor Author

PR merged & I have updated the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@benbp benbp Awaiting requested review from benbp

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konrad-jamrozik @heaths @weshaggard