Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "npm ci" to install cspell and respect package-lock.json #5595

Merged
3 commits merged into from
Mar 3, 2023
Merged

Use "npm ci" to install cspell and respect package-lock.json #5595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ffa426
Use "npm ci" to install cspell and respect package-lock.json
danieljurek Mar 1, 2023
aa87905
Review feedback
danieljurek Mar 2, 2023
87370bb
Pipe npm ci output to Write-Host
danieljurek Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions eng/common/spelling/Invoke-Cspell.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ created in the temp folder, package*.json files will be placed in that folder.
.PARAMETER LeavePackageInstallCache
If set the PackageInstallCache will not be deleted. Use if there are multiple
calls to Invoke-Cspell.ps1 to prevent creating multiple working directories and
redundant calls `npm install`.
redundant calls `npm ci`.

.PARAMETER Test
Run test functions against the script logic
Expand Down Expand Up @@ -167,9 +167,7 @@ $originalLocation = Get-Location

try {
Set-Location $PackageInstallCache
npm install npx | Out-Null
npm install cspell | Out-Null
npm install | Out-Null
npm ci | Write-Host

# Use the mutated configuration file when calling cspell
$command = "npx cspell $JobType --config $CSpellConfigPath --no-must-find-files --root $SpellCheckRoot --relative"
Expand Down