Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret rotation tool #5564

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add secret rotation tool #5564

merged 3 commits into from
Feb 27, 2023

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Feb 23, 2023 •
edited
Loading

This migrates the contents of the rotation tool from azure-ask-build-tool's master branch as of commit 9a18fc with the following changes:

  • Directory.Build.props imports repo root Directory.Build.props
  • proj files no longer set properties made redundant by Directory.Build.props
  • cli configured to pack as a tool
  • documentation added to docs folder
  • json schema added to Configuration project
  • planned implementation removed from Readme

@hallipr hallipr requested a review from a team as a code owner February 23, 2023 22:47
benbp
benbp approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is the full copy of the internal repo that I already reviewed, +1

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Feb 24, 2023 •
edited
Loading

Maybe you could link from the PR description the the PR review we did on the internal repo?

In general, kind of scary to see such a big addition with an empty PR description :D

@hallipr
Copy link
Member Author

hallipr commented Feb 27, 2023

Overriding check enforcer as there's no validation pipeline

@hallipr
Copy link
Member Author

hallipr commented Feb 27, 2023

/check-enforcer override

@hallipr hallipr merged commit aa46c1c into main Feb 27, 2023
@hallipr hallipr deleted the users/pahallis/secret-rotation branch February 27, 2023 22:44
@hallipr hallipr mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@benbp benbp benbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hallipr @konrad-jamrozik @benbp @weshaggard