-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIView changes to send emails using logic app service #5408
Merged
praveenkuttappan
merged 6 commits into
Azure:main
from
praveenkuttappan:feature/update_apiview_email_sender
Feb 16, 2023
Merged
APIView changes to send emails using logic app service #5408
praveenkuttappan
merged 6 commits into
Azure:main
from
praveenkuttappan:feature/update_apiview_email_sender
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
force-pushed
the
feature/update_apiview_email_sender
branch
from
February 13, 2023 17:40
79df610
to
ba205bd
Compare
weshaggard
reviewed
Feb 13, 2023
weshaggard
reviewed
Feb 13, 2023
weshaggard
reviewed
Feb 13, 2023
weshaggard
reviewed
Feb 13, 2023
weshaggard
reviewed
Feb 13, 2023
weshaggard
reviewed
Feb 13, 2023
weshaggard
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Lets make sure we get some good testing on this change.
Co-authored-by: Wes Haggard <[email protected]>
Fixes #4670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIView was using SendGrid to send email notifications and this has a limitation in number of emails we can send. This PR has a change to send emails using Azure logic app service added in Azure subscription instead of sendgrid.