Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-proxy contributing.md #5403

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 10, 2023

@mario-guerra when you have a couple minutes please take a look.

Resolves #5392

@scbedd scbedd requested a review from mikeharder as a code owner February 10, 2023 20:03
@scbedd scbedd self-assigned this Feb 10, 2023
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Feb 10, 2023
@mario-guerra
Copy link
Member

@scbedd I took a quick pass through the doc and it looks good. I'd like to delve into it a bit deeper and follow along with the instructions to see if I can successfully make a change and build the project before we commit this doc. I will do that early next week.

Copy link
Member

@kurtzeborn kurtzeborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@scbedd scbedd merged commit 949a349 into Azure:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create test-proxy CONTRIBUTING.md
5 participants