Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwaggerAPIView upgrade to dotnet7 #5399

Closed
wants to merge 4 commits into from
Closed

SwaggerAPIView upgrade to dotnet7 #5399

wants to merge 4 commits into from

Conversation

ruowan
Copy link
Member

@ruowan ruowan commented Feb 10, 2023

No description provided.

@ruowan ruowan requested a review from a team as a code owner February 10, 2023 04:42
@ruowan ruowan changed the title Wrx dev Upgrade to dotnet7 Feb 10, 2023
@ruowan ruowan changed the title Upgrade to dotnet7 SwaggerAPIView upgrade to dotnet7 Feb 10, 2023
@ruowan
Copy link
Member Author

ruowan commented Feb 10, 2023 •
edited
Loading

@konrad-jamrozik Help to review this PR. I think I need to upgrade dotnet7

konrad-jamrozik
konrad-jamrozik approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruowan this should just work. I am just curious: why you need to update to .NET 7?

@ruowan
Copy link
Member Author

ruowan commented Feb 13, 2023

The dotnet version in global.json is 7. So to keep it consistent, we need to update the dotnet version in swagger-api-parser tools.

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Feb 13, 2023 •
edited
Loading

The dotnet version in global.json is 7. So to keep it consistent, we need to update the dotnet version in swagger-api-parser tools.

@ruowan Just to be clear: it will also work with .NET 6. We had a long discussion about it, and a series of PRs, here:

But nevertheless update to 7.0 is a-ok:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 13, 2023
@praveenkuttappan praveenkuttappan self-assigned this Feb 28, 2023
@praveenkuttappan praveenkuttappan marked this pull request as draft March 7, 2023 20:07
@github-actions
Copy link

Hi @ruowan. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 12, 2023
@github-actions
Copy link

Hi @ruowan. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad-jamrozik konrad-jamrozik konrad-jamrozik approved these changes

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu chidozieononiwu will be requested when the pull request is marked ready for review chidozieononiwu is a code owner

Assignees

@praveenkuttappan praveenkuttappan

Labels
Central-EngSys This issue is owned by the Engineering System team. no-recent-activity There has been no recent activity on this issue.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruowan @konrad-jamrozik @praveenkuttappan