Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install .NET 6.0.x runtime. Remove DotNetCoreVersion param. Undo DOTNET_ROLL_FORWARD. #5395

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 10, 2023

Update 2/10/2023

This PR got reverted by

and then redone by


Changes made per this comment:

and my discussion with @weshaggard

We were already using the newest .NET SDK to build things; it comes from global.json. But with this PR, we also install .NET 6.0.x runtime, so that our tooling targeting it runs against it.

A note on parameter support

I have removed DotNetCoreVersion because:

  • Setting global.json .NET to 6.0.x and trying to override with DotNetCoreVersion 7.0.x does not work (<- this may not be true, but we want to have newest .NET in global.json anyway).
  • Setting global.json .NET to 7.0.x and overriding with DotNetCoreVersion 6.0.x would work, but then the parameter would have to be passed in many places, as most of our tools target 6.0.x.
  • We could change the DotNetCoreVersion to something like SkipRuntimeInstall; in such case, the .NET 6.0.x would be installed by default, but then for tools migrated to 7.0.x one could skip it by passing SkipRuntimeInstall. Once all tools are migrated to 7.0.x we could update this file to no longer install 6.0.x runtime and get rid of all such SkipRuntimeInstall arguments. However, this seems to me as some amount of work not necessarily worth the effort.

Having said that, once we need more flexibility for the runtimes installed, we could add the param back.

Testing done

This build confirms that an assembly targeting 7.0.x works (I made Azure.Sdk.Tools.RetrieveCodeOwners and Azure.Sdk.Tools.CodeOwnsersParser target 7.0.0 for this build):

This build confirms that an assembly targeting 6.0.x works:

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 10, 2023
@konrad-jamrozik konrad-jamrozik requested a review from a team as a code owner February 10, 2023 00:05
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 10, 2023
@konrad-jamrozik konrad-jamrozik changed the title Install .NET 7.0.x from global.json and .NET 6.0.0 runtime. Remove DotNetCoreVersion param. Undo DOTNET_ROLL_FORWARD. Install .NET 6.0.x runtime. Remove DotNetCoreVersion param. Undo DOTNET_ROLL_FORWARD. Feb 10, 2023
version: 6.0.x
# performMultiLevelLookup comes into play when given .NET executable target runtime is different
# than the installed .NET SDK. Without this, such runtime would not be found.
performMultiLevelLookup: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see this on the SDK install above. Did you try to verify if we need to explicitly have this step for the 6 runtime?

Copy link
Contributor Author

@konrad-jamrozik konrad-jamrozik Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konrad-jamrozik konrad-jamrozik changed the title Install .NET 6.0.x runtime. Remove DotNetCoreVersion param. Undo DOTNET_ROLL_FORWARD. Install .NET 6.0.x runtime. Remove DotNetCoreVersion param. Undo DOTNET_ROLL_FORWARD. Feb 10, 2023
@konrad-jamrozik konrad-jamrozik merged commit 3efd680 into main Feb 10, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/revert_rollForward branch February 10, 2023 01:14
konrad-jamrozik pushed a commit that referenced this pull request Feb 10, 2023
…ime. Remove `DotNetCoreVersion` param. (#5395)"

This reverts commit 3efd680.
konrad-jamrozik pushed a commit that referenced this pull request Feb 10, 2023
…ime. Remove `DotNetCoreVersion` param. (#5395)" (#5398)
konrad-jamrozik pushed a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants