-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install .NET 6.0.x
runtime. Remove DotNetCoreVersion
param. Undo DOTNET_ROLL_FORWARD
.
#5395
Conversation
…ove `DotNetCoreVersion` param.
.NET 7.0.x
from global.json
and .NET 6.0.0
runtime. Remove DotNetCoreVersion
param. Undo DOTNET_ROLL_FORWARD
..NET 6.0.x
runtime. Remove DotNetCoreVersion
param. Undo DOTNET_ROLL_FORWARD
.
version: 6.0.x | ||
# performMultiLevelLookup comes into play when given .NET executable target runtime is different | ||
# than the installed .NET SDK. Without this, such runtime would not be found. | ||
performMultiLevelLookup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to see this on the SDK install above. Did you try to verify if we need to explicitly have this step for the 6 runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our chat, these builds show the behavior on performMultiLevelLookup
for SDK:
(source)
For 6.0 target (fails):
For 7.0 target (works):
.NET 6.0.x
runtime. Remove DotNetCoreVersion
param. Undo DOTNET_ROLL_FORWARD
..NET 6.0.x
runtime. Remove DotNetCoreVersion
param. Undo DOTNET_ROLL_FORWARD
.
…ove `DotNetCoreVersion` param. (#5395)
Update 2/10/2023
This PR got reverted by
.NET 7.0.x
fromglobal.json
and.NET 6.0.0
runtime. RemoveDotNetCoreVersion
param. (#5395)" #5398and then redone by
.NET 6.0.x
SDK. RemoveDotNetCoreVersion
param.Undo DOTNET_ROLL_FORWARD
- take 2 #5405Changes made per this comment:
.NET
from6.0.403
to7.0.102
+DOTNET_ROLL_FORWARD
:Major
+ fix wrong quotes ininstall-net.yml
#5379 (comment)and my discussion with @weshaggard
We were already using the newest .NET SDK to build things; it comes from
global.json
. But with this PR, we also install.NET 6.0.x
runtime, so that our tooling targeting it runs against it.A note on parameter support
I have removed
DotNetCoreVersion
because:global.json
.NET
to6.0.x
and trying to override withDotNetCoreVersion 7.0.x
does not work (<- this may not be true, but we want to have newest .NET inglobal.json
anyway).global.json
.NET
to7.0.x
and overriding withDotNetCoreVersion 6.0.x
would work, but then the parameter would have to be passed in many places, as most of our tools target6.0.x
.DotNetCoreVersion
to something likeSkipRuntimeInstall
; in such case, the.NET 6.0.x
would be installed by default, but then for tools migrated to7.0.x
one could skip it by passingSkipRuntimeInstall
. Once all tools are migrated to7.0.x
we could update this file to no longer install6.0.x
runtime and get rid of all suchSkipRuntimeInstall
arguments. However, this seems to me as some amount of work not necessarily worth the effort.Having said that, once we need more flexibility for the runtimes installed, we could add the param back.
Testing done
This build confirms that an assembly targeting
7.0.x
works (I madeAzure.Sdk.Tools.RetrieveCodeOwners
andAzure.Sdk.Tools.CodeOwnsersParser
target7.0.0
for this build):This build confirms that an assembly targeting
6.0.x
works: