Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upgrade to Bootstrap 5 #5385

Merged
merged 15 commits into from
Feb 11, 2023
Merged

Feature/upgrade to Bootstrap 5 #5385

merged 15 commits into from
Feb 11, 2023

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Feb 9, 2023 •
edited
Loading

  • Upgrade of bootstraps to latest version.
  • Replacement of dropdown select component.
  • Re-organization page settings.
  • Improvements to style code.
  • Improvements to review code panel.
  • Some improvements to theming.

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner February 9, 2023 04:15
@chidozieononiwu chidozieononiwu force-pushed the feature/UpgradeToBootstraps5 branch from 1e7163c to 9156fa1 Compare February 9, 2023 04:23
@chidozieononiwu chidozieononiwu requested review from praveenkuttappan and removed request for praveenkuttappan February 9, 2023 04:24
@chidozieononiwu chidozieononiwu self-assigned this Feb 9, 2023
@chidozieononiwu chidozieononiwu force-pushed the feature/UpgradeToBootstraps5 branch 6 times, most recently from 273d7b0 to 23f4300 Compare February 9, 2023 07:21
@chidozieononiwu chidozieononiwu force-pushed the feature/UpgradeToBootstraps5 branch from 23f4300 to 85445cc Compare February 9, 2023 17:54
@chidozieononiwu chidozieononiwu added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 9, 2023
praveenkuttappan
praveenkuttappan approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@konrad-jamrozik konrad-jamrozik changed the title Feature/upgrade to bootstraps5 Feature/upgrade to Bootstrap 5 Feb 10, 2023
@chidozieononiwu chidozieononiwu force-pushed the feature/UpgradeToBootstraps5 branch from b4a1de4 to 66f1f91 Compare February 11, 2023 02:56
@chidozieononiwu chidozieononiwu merged commit 753f295 into Azure:main Feb 11, 2023
This was referenced Feb 11, 2023
Closed
Closed
This was referenced Feb 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

Assignees

@chidozieononiwu chidozieononiwu

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @praveenkuttappan