-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info/Active/
now offers data for individual sessions
#5384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Feb 9, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Properties/launchSettings.json
Show resolved
Hide resolved
scbedd
commented
Feb 9, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Views/Info/ActiveExtensions.cshtml
Outdated
Show resolved
Hide resolved
scbedd
changed the title
Feature/active details recording
Feb 9, 2023
Info/Active/
now offers data for individual sessions
…s/matchers. need to properly fix this but not worth the time for a feature that is relatively low usage
…coding the string 'BackingField' exclusion
hallipr
approved these changes
Feb 14, 2023
tools/test-proxy/Azure.Sdk.Tools.TestProxy/Models/ActiveMetadataModel.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5362
@samvaity is working on transition appconfiguration to test-proxy for java. As she was doing that, she wanted to see the
order of application
of the sanitizers after they are registered. This is because the java framework does a lot of behind-the-scenes work to pregister more than a few sanitizers.It is a much easier experience to debug if folks can actually see the session level customizations when they view the
Info/Active
page.Of course, the proviso is that you can't get active information for a recording or playback session that has ended, but the test-proxy should enable this regardless.
How to use it? Before your recording stops, and while you have that recordingId on hand, hit a browser with URL:
<proxyurl>/Info/Active?id=<recordingId>
TODO:
BackingField
that is showing up onRecordedTestSanitizer
, by excluding any of the fields that show up on the base classesRecordedTestSanitizer
,ResponseTransform
, andRecordMatcher
. These don't offer any customizations, so we can safely exclude their fields.