Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info/Active/ now offers data for individual sessions #5384

Merged
merged 9 commits into from
Feb 15, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 9, 2023

Resolves #5362

@samvaity is working on transition appconfiguration to test-proxy for java. As she was doing that, she wanted to see the order of application of the sanitizers after they are registered. This is because the java framework does a lot of behind-the-scenes work to pregister more than a few sanitizers.

It is a much easier experience to debug if folks can actually see the session level customizations when they view the Info/Active page.

Of course, the proviso is that you can't get active information for a recording or playback session that has ended, but the test-proxy should enable this regardless.

How to use it? Before your recording stops, and while you have that recordingId on hand, hit a browser with URL:

<proxyurl>/Info/Active?id=<recordingId>

TODO:

  • Honor argument with optional specific recordingId
  • Confirm via visual inspection that content is rendering properly
  • We are patching out the odd BackingField that is showing up on RecordedTestSanitizer, by excluding any of the fields that show up on the base classes RecordedTestSanitizer, ResponseTransform, and RecordMatcher. These don't offer any customizations, so we can safely exclude their fields.
  • Add error page for unrecognized recording Id

@scbedd scbedd added the Test-Proxy Anything relating to test-proxy requests or issues. label Feb 9, 2023
@scbedd scbedd self-assigned this Feb 9, 2023
@scbedd scbedd requested a review from mikeharder as a code owner February 9, 2023 03:34
@scbedd scbedd changed the title Feature/active details recording Info/Active/ now offers data for individual sessions Feb 9, 2023
…s/matchers. need to properly fix this but not worth the time for a feature that is relatively low usage
@scbedd scbedd merged commit 76afc9b into Azure:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test-Proxy Anything relating to test-proxy requests or issues.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Info/Active to reveal recordingId-specific details
2 participants