Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign issue when Test-Proxy label is used #5382

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

mario-guerra
Copy link
Member

No description provided.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with approving this for now, but once the EngSys replacement for Fabric Bot is ready, this will need to move to CODEOWNERS in order for it to be included for automated triage.

@mario-guerra
Copy link
Member Author

Thanks @jsquire. Once the Fabric Bot replacement is ready, will the move to CODEOWNERS happen automagically or will it require a manual change?

@jsquire
Copy link
Member

jsquire commented Feb 9, 2023

It will require manual updates. We do not have a fully automated triage process today and team assignments are manual so there's no existing data to convert. We'll need to create a new set for team-owned labels in all repositories.

@mario-guerra
Copy link
Member Author

Thanks again @jsquire. I see that checkenforcer is listed as pending but when I click through the details it shows as completed. Is there a snag in the update logic or does it just take time?

@jsquire
Copy link
Member

jsquire commented Feb 9, 2023

Checkenforcer doesn't play nice when there's not code being updated. It needs to be manually overridden for these kinds of assets.

@jsquire
Copy link
Member

jsquire commented Feb 9, 2023

/check-enforcer override

@mario-guerra mario-guerra merged commit de045af into main Feb 9, 2023
@mario-guerra mario-guerra deleted the test_proxy_label_assign branch February 9, 2023 17:41
@mario-guerra
Copy link
Member Author

@jsquire can I make the change to CODEOWNERS now without messing anything up? I see Scott B and Mike H are already code owners for the test proxy, I would just add myself to the list.

@jsquire
Copy link
Member

jsquire commented Feb 9, 2023

You're welcome to update it, but that will just assign you as a reviewer for PRs. The structure that will be necessary doesn't exist today and the final format is not yet finalized.

@kurtzeborn
Copy link
Member

@jsquire is this a feature (email notifications) be something we add to your gist that @JimSuplizio is working off of? Is Mario the first to do this (to your knowledge) using FabricBot?

@jsquire
Copy link
Member

jsquire commented Feb 10, 2023

Email notifications are automatic in GitHub when assignments/mentions take place. Part of the bot workflow will be fully automating triage, so once we have the needed functionality, registering as an owner will cause assignment and email notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants