[JS] Capture profiling artifacts #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harshan/set-profiling-artifacts
HarshaNalluru
commented
Feb 13, 2023
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
mikeharder
requested changes
Feb 16, 2023
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/ILanguage.cs
Outdated
Show resolved
Hide resolved
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
…t.cs Co-authored-by: Mike Harder <[email protected]>
HarshaNalluru
commented
Feb 17, 2023
tools/perf-automation/Azure.Sdk.Tools.PerfAutomation/JavaScript.cs
Outdated
Show resolved
Hide resolved
…t.cs Co-authored-by: Mike Harder <[email protected]>
…harshanalluru/azure-sdk-tools into harshan/set-profiling-artifacts
mikeharder
approved these changes
Feb 18, 2023
HarshaNalluru
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Feb 21, 2023
Fixes #14146 Validation: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2201082&view=results ## What's in the PR? Adds two new options to add profiling support to the perf framework ``` profile = "Set to true to profile the perf test. When set to true, `cpus` will be overriden to 1." (defaults to false) profile-filepath = "Used as the artifact path" (optional) ``` Counterpart in the tools repo Azure/azure-sdk-tools#5369 ## Example generated profile <img width="1125" alt="image" src="https://user-images.githubusercontent.com/10452642/218958379-4c62386b-530a-4f3f-84bd-49d51d41bfd4.png"> --------- Co-authored-by: Jeff Fisher <[email protected]> Co-authored-by: Timo van Veenendaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The counterpart in the JS repo Azure/azure-sdk-for-js#24240
Validation: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2201082&view=results