Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multi-line string concatenation with Write-Warning #5313

Merged
1 commit merged into from
Feb 2, 2023
Merged

Handle multi-line string concatenation with Write-Warning #5313

1 commit merged into from
Feb 2, 2023

Conversation

benbp
Copy link
Member

@benbp benbp commented Feb 2, 2023

No description provided.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Feb 2, 2023
@benbp benbp self-assigned this Feb 2, 2023
@benbp benbp requested a review from kristapratico February 2, 2023 00:41
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
heaths
heaths approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Didn't think that wouldn't work.

@benbp
Copy link
Member Author

benbp commented Feb 2, 2023

Me neither! It gives the following error:

Write-Warning: A positional parameter cannot be found that accepts argument '+'.

@ghost
Copy link

ghost commented Feb 2, 2023

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit fb8eeea into Azure:main Feb 2, 2023
@kristapratico kristapratico mentioned this pull request Feb 2, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@weshaggard weshaggard weshaggard approved these changes

@heaths heaths heaths approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benbp @azure-sdk @heaths @weshaggard @kristapratico