-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suffix *
handling in our CODEOWNERS
path matcher
#5308
Merged
konrad-jamrozik
merged 3 commits into
main
from
users/kojamroz/fix_suffix_single_star_handling
Feb 2, 2023
Merged
Fix suffix *
handling in our CODEOWNERS
path matcher
#5308
konrad-jamrozik
merged 3 commits into
main
from
users/kojamroz/fix_suffix_single_star_handling
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
This issue is owned by the Engineering System team.
label
Feb 1, 2023
konrad-jamrozik
changed the title
Fix suffix single start handling in our
Fix suffix Feb 1, 2023
CODEOWNERS
path matcher*
handling in our CODEOWNERS
path matcher
konrad-jamrozik
force-pushed
the
users/kojamroz/fix_suffix_single_star_handling
branch
from
February 1, 2023 21:56
636a63c
to
94f785a
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/fix_suffix_single_star_handling
branch
from
February 1, 2023 21:58
94f785a
to
c69c9ce
Compare
weshaggard
approved these changes
Feb 2, 2023
@weshaggard I made some significant changes since you approved; turns out, GitHub's CODEOWNERS matching logic is a bit inconsistent when it comes to handling suffixes. I did manual tests using my own scratchpad repo to confirm its behavior. The behavior is explained here. In a nutshell:
|
konrad-jamrozik
force-pushed
the
users/kojamroz/fix_suffix_single_star_handling
branch
3 times, most recently
from
February 2, 2023 06:49
19fc6e0
to
3a38250
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/fix_suffix_single_star_handling
branch
from
February 2, 2023 06:50
3a38250
to
446a087
Compare
weshaggard
reviewed
Feb 2, 2023
weshaggard
approved these changes
Feb 2, 2023
konrad-jamrozik
deleted the
users/kojamroz/fix_suffix_single_star_handling
branch
February 2, 2023 19:54
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in subject. Prompted by this comment thread:
CODEOWNERS
azure-sdk-for-python#28539 (comment)There were some other issues with the matcher being inconsistent with GitHub's matcher. For details, please see this comment:
*
handling in ourCODEOWNERS
path matcher #5308 (comment)This PR contributes to: