Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert naming test-proxy #5283

Closed
wants to merge 14 commits into from
Closed

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 31, 2023

This PR updates the matrix to also pass through the assembly name, as we can't automagically infer which of the files in the standalone matrix is a .exe on linux/mac.

Save ourselves the downstream pain of:

  • not aligning with the namespace (which plays hell with the .net usage of this thing)
  • needing to worry about name squatters (generic test-proxy being the name :|)
  • fixing the numerous other places I have probably broken stuff by the rename

Just...just save myself the pain.

spoiler alert

I did not save myself anything unfortunately. I have discovered all of these issues with the latest eng/common update that involves this. Reverting, updating that eng/common one last time, and hopefully being done with this.

@scbedd scbedd requested a review from mikeharder as a code owner January 31, 2023 07:01
@scbedd scbedd self-assigned this Jan 31, 2023
@scbedd scbedd added Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues. labels Jan 31, 2023
@scbedd scbedd requested a review from benbp January 31, 2023 07:03
@scbedd
Copy link
Member Author

scbedd commented Jan 31, 2023

Real talk though I think this was an ill-advised change to make the standalone executable a bit nicer to use. At the end of the day I don't think that anyone will really care about the difference between test-proxy and azure.sdk.tools.testproxy when it's the same binary under the hood.

@scbedd
Copy link
Member Author

scbedd commented Jan 31, 2023

This is going to require another update of azure-sdk-build-tools to fix, due to the fact that the method of detecting the binary is flawed.

It's my code so I can't be sad about it.

@scbedd scbedd requested a review from a team as a code owner February 1, 2023 20:49
@scbedd
Copy link
Member Author

scbedd commented Feb 1, 2023

This is going to come through the same avenue as a previous build that required azure-sdk-build-tools update. Will kludge these changes into the automatically submitted sdk-build-tools reference update. Closing.

@scbedd scbedd closed this Feb 1, 2023
@scbedd
Copy link
Member Author

scbedd commented Feb 1, 2023

This PR is now reflected in the sdk-build-tools update PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants