-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert naming test-proxy
#5283
Revert naming test-proxy
#5283
Conversation
Real talk though I think this was an ill-advised change to make the standalone executable a bit nicer to use. At the end of the day I don't think that anyone will really care about the difference between |
This is going to require another update of It's my code so I can't be sad about it. |
eng/pipelines/templates/scripts/assemble-dotnet-standalone-exe.ps1
Outdated
Show resolved
Hide resolved
This is going to come through the same avenue as a previous build that required |
This PR is now reflected in the sdk-build-tools update PR. |
This PR updates the matrix to also pass through the assembly name, as we can't automagically infer which of the files in the standalone matrix is a
.exe
on linux/mac.Save ourselves the downstream pain of:
test-proxy
being the name :|)Just...just save myself the pain.spoiler alert
I did not save myself anything unfortunately. I have discovered all of these issues with the latest eng/common update that involves this. Reverting, updating that eng/common one last time, and hopefully being done with this.