Repair failing test-proxy livetests #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t leave stuff around accidentally)
scbedd
changed the title
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the issue. When we are using a token for push/pull, we are now unable to
git statuswithout a remote configuration that actually works. It fails with error code 128 andterminal prompts are now disabled. The reason this is happening is becausegit statusis now erroring when it can't find a global configuration for a given user. This is where it would prompt you for a user/pass combo -- something which is disabled in CI for a reason!The token being present in the origin url short circuits this error and allows it to infer the username automagically, which is why this solution works.
Kinda glad this occurred here before someone started asking
This PR moves the update of the origin to include the token to before we DetectPendingChanges. Frankly, this kinda makes sense, and I'm actually uncertain why it ever worked other than "git updates".
TERMINAL_PROMPTenvironment variable, it doesn't address the issue. The update ofSetOriginis all that is required.