Batch background review update when parser version changes #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4723 |
| @@ -33,6 +36,18 @@ public ReviewBackgroundHostedService(IReviewManager reviewManager, IConfiguratio | |||
| { | |||
| _autoArchiveInactiveGracePeriodMonths = 4; | |||
| } | |||
| var backgroundTaskDisabledLangs = configuration["ReviewUpdateDisabledLanguages"]; | |||
| if(!string.IsNullOrEmpty(backgroundTaskDisabledLangs)) | |||
There was a problem hiding this comment.
Suggested change
| if(!string.IsNullOrEmpty(backgroundTaskDisabledLangs)) | |
| if (!string.IsNullOrEmpty(backgroundTaskDisabledLangs)) |
There was a problem hiding this comment.
I had missed this comment. I will pull in this change in my next PR. thanks @konrad-jamrozik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API review is updated when parser version changes as part of background task during server startup. This causes too many pipelines running in parallel when running one pipeline for each review to be updated. This PR has changes to: