Add global.json and other missing paths to CODEOWNERS
#5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
|
@weshaggard should other files in root dir also be added to CODEOWNERS? In general, our CODEOWNERS file is not covering many files and dirs.
|
konrad-jamrozik
changed the title
|
Yes we should probably include all the root files perhaps * works for that. |
konrad-jamrozik
changed the title
global.json and other missing files to CODEOWNERS
|
@weshaggard I added rules to cover everything in repo: https://github.com/Azure/azure-sdk-tools/pull/5044/files |
konrad-jamrozik
changed the title
global.json and other missing files to CODEOWNERSglobal.json and other missing paths to CODEOWNERS
weshaggard
reviewed
Jan 4, 2023
weshaggard
reviewed
Jan 4, 2023
weshaggard
reviewed
Jan 4, 2023
weshaggard
reviewed
Jan 4, 2023
weshaggard
reviewed
Jan 4, 2023
weshaggard
reviewed
Jan 4, 2023
|
@konrad-jamrozik I'm good with what you have except for the artifacts would should be removed. The other comments are more brain dumping from me of more clean-up I would like to do in the tools repo at some point. |
weshaggard
approved these changes
Jan 4, 2023
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to:
global.jsonfor .NET usage in our templates #5009With this PR merged, the CODEOWNERS file should have 100% coverage of all files and directories currently in the repository.