Update ubuntu-latest images: set them to Ubuntu 22.04 XOR comment they are latest intentionally
#5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2022 18:22
… latest on purpose
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
commented
Dec 21, 2022
|
|
||
| pool: | ||
| name: azsdk-pool-mms-ubuntu-2204-general | ||
| vmImage: MMSUbuntu22.04 |
There was a problem hiding this comment.
This pool is the actual change. Not sure why entire file shows as diffed; perhaps due to automatic line endings conversion.
konrad-jamrozik
commented
Jan 5, 2023
konrad-jamrozik
requested review from
changlong-liu,
tadelesh,
dw511214992,
qiaozha,
MaryGao,
a team,
jsquire and
ronniegeraghty
as code owners
weshaggard
approved these changes
Jan 10, 2023
|
@weshaggard I am going to override check-enforcer and merge this PR in spite of |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to:
In this PR, I migrate occurrences of
ubuntu-latestto Ubuntu 22.04 XOR I add a comment explaining they are intentionally set tolatest.I do not have enough context to guess which images should be updated - this is just my best guess. Thus I kindly ask reviewers to verify if my guess is correct.
This PR has revealed following issue:
mock-service-host citests on Windows time out after 1h #5102