Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/block auto review revision updates #4980

Conversation

praveenkuttappan
Copy link
Member

@praveenkuttappan praveenkuttappan commented Dec 15, 2022

Hide button to add new revision for automatic and manual reviews

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Dec 15, 2022
@praveenkuttappan praveenkuttappan requested a review from a team as a code owner December 15, 2022 18:04
@praveenkuttappan praveenkuttappan self-assigned this Dec 15, 2022
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Revisions.cshtml LGTM.
I imagine the other changes are from another work that you based your branch from.

@maririos
Copy link
Member

Could you make sure to close #4814 ?

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question related to multiple reviews but otherwise looks good assuming the pat has the necessary permissions to the repo.

@praveenkuttappan praveenkuttappan force-pushed the feature/block_auto_review_revision_updates branch from 55ee7e8 to 596c191 Compare December 19, 2022 21:05
@praveenkuttappan praveenkuttappan force-pushed the feature/block_auto_review_revision_updates branch from 9725297 to db85017 Compare December 19, 2022 21:28
@praveenkuttappan praveenkuttappan merged commit b5b1792 into Azure:main Dec 20, 2022
@praveenkuttappan praveenkuttappan deleted the feature/block_auto_review_revision_updates branch December 20, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants