Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI improvements/approve buttons #4812

Merged
6 commits merged into from
Feb 1, 2023
Merged

UI improvements/approve buttons #4812

6 commits merged into from
Feb 1, 2023

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Nov 29, 2022 •
edited
Loading

AprrovalStuff

ApproveDropdown

- Should resolve https://github.com//issues/4627

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner November 29, 2022 03:29
@chidozieononiwu chidozieononiwu mentioned this pull request Nov 29, 2022
Closed
@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from f6b4e2e to 6a0efe9 Compare November 29, 2022 19:39
@chidozieononiwu chidozieononiwu self-assigned this Nov 29, 2022
@maririos
Copy link
Member

@chidozieononiwu do you have a screenshot on how this change looks now? or is it deployed into the apiviewuat instance?

@chidozieononiwu
Copy link
Member Author

chidozieononiwu commented Nov 29, 2022 •
edited
Loading

@chidozieononiwu do you have a screenshot on how this change looks now? or is it deployed into the apiviewuat instance?

I have it deployed to https://apiviewuat.azurewebsites.net/ you have to be an approving architect to view the effect though.

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from 6a0efe9 to 99215b1 Compare November 29, 2022 23:24
@ladonnaq ladonnaq mentioned this pull request Dec 7, 2022
Closed
15 tasks
@praveenkuttappan
Copy link
Member

Please make a change as per suggestion from Ted to change the first approve button label to Approval for GA. Otherwise looks fine.

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from 99215b1 to 90590e2 Compare January 27, 2023 23:14
@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch 3 times, most recently from 012b65d to 08debd2 Compare January 30, 2023 19:22
@chidozieononiwu
Copy link
Member Author

/azp run APIView - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch 2 times, most recently from 8587898 to 7717214 Compare January 30, 2023 21:53
@chidozieononiwu
Copy link
Member Author

/azp run APIView - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from 7717214 to 2373846 Compare January 31, 2023 22:24
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu
Copy link
Member Author

/azp run APIView - CI

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from 2373846 to d6dd236 Compare January 31, 2023 23:37
@chidozieononiwu
Copy link
Member Author

/azp run APIView - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@chidozieononiwu chidozieononiwu force-pushed the UIImprovements/ApproveButtons branch from d6dd236 to d6909e9 Compare February 1, 2023 04:08
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 1, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Feb 1, 2023

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit a661266 into Azure:main Feb 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konrad-jamrozik konrad-jamrozik konrad-jamrozik left review comments

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

@tg-msft tg-msft Awaiting requested review from tg-msft

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

Assignees

@chidozieononiwu chidozieononiwu

Labels
None yet
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chidozieononiwu @maririos @praveenkuttappan @azure-sdk @konrad-jamrozik