Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/miscellaneous improvements #4206

Merged

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Sep 22, 2022

@praveenkuttappan
Copy link
Member

Is there any issue to link to this PR?

@chidozieononiwu chidozieononiwu self-assigned this Sep 22, 2022
@chidozieononiwu chidozieononiwu force-pushed the bugFix/miscellaneousImprovements branch from 6b8b09c to 807e499 Compare September 22, 2022 20:59
@JonathanGiles
Copy link
Member

Regarding the changes to the expand / collapse doc feature, just an FYI that @Vailorium is currently working in this area too to fix some issues (see #4052). There will potentially be some merge conflicts here.

@JonathanGiles
Copy link
Member

I wonder if we should try to connect the vertical line with the box, to make it super clear which box is associated with which ref doc - otherwise I worry that if we expand two comments next to each other, it might be less clear which box is related to which ref doc:

image

@chidozieononiwu chidozieononiwu force-pushed the bugFix/miscellaneousImprovements branch from 807e499 to e26fff6 Compare September 22, 2022 23:31
@chidozieononiwu
Copy link
Member Author

I wonder if we should try to connect the vertical line with the box, to make it super clear which box is associated with which ref doc - otherwise I worry that if we expand two comments next to each other, it might be less clear which box is related to which ref doc:

image

I resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants