-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-Proxy GZip Hotfix #4169
Test-Proxy GZip Hotfix #4169
Conversation
The following pipelines have been queued for testing: |
@JoshLove-msft I actually think that we lucked out in how this bug broke people. We were doing things straight up wrong, and as a result I believe folks just disabled body matching where they hit this issue. I think that was literally everyone because I have an eng/common update build against core here and it's green (except for something that I believe is unrelated). Notice the failure in group0 existed before I updated the actual version of the test-proxy in package props. I've run a ton of other builds as well and they're all green except for JS test-utils. I'm going to get the js-tests green and then just merge the eng/common PRs across the board. Do you have an opposition to that plan? |
Sounds good - we used the same strategy of disabling body matching in .NET. /cc @nisha-bhatia |
The following pipelines have been queued for testing: |
/check-enforcer override |
@JoshLove-msft went out of his way to contribute a bugfix via #4165
However, given the fact that this probably breaks recordings where
gzip
is present...we'll need to re-record tests. We will do that in each corresponding auto-created branch from this PR.