-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary checkout: none that causes conflicts with sparse checkout declarations #4041
Conversation
…heckout declarations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we are already fixed the consumers so they don't end up with full clones.
The following pipelines have been queued for testing: |
@weshaggard yeah that was actually how I found this problematic line. I fixed the consumers, which worked for all my test cases, but it broke the spring-experimental CI/release pipeline. All our release pipelines across languages were doing full clones before these two fixes. |
Validated against https://dev.azure.com/azure-sdk/internal/_build?definitionId=4739 which now renders valid yaml. FYI @stliu @moarychan |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This was causing
checkout: none
to appear twice in release pipeline yaml, which caused someone to addSkipDefaultCheckout
to the sparse checkout parameters in order to avoid the conflict. However, this meant that we were then doing full clones in some places.