Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary checkout: none that causes conflicts with sparse checkout declarations #4041

Merged
1 commit merged into from
Sep 1, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Aug 31, 2022

This was causing checkout: none to appear twice in release pipeline yaml, which caused someone to add SkipDefaultCheckout to the sparse checkout parameters in order to avoid the conflict. However, this meant that we were then doing full clones in some places.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 31, 2022
@benbp benbp self-assigned this Aug 31, 2022
@benbp benbp requested a review from hallipr August 31, 2022 20:19
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we are already fixed the consumers so they don't end up with full clones.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Aug 31, 2022

I assume we are already fixed the consumers so they don't end up with full clones.

@weshaggard yeah that was actually how I found this problematic line. I fixed the consumers, which worked for all my test cases, but it broke the spring-experimental CI/release pipeline. All our release pipelines across languages were doing full clones before these two fixes.

@benbp
Copy link
Member Author

benbp commented Aug 31, 2022

Validated against https://dev.azure.com/azure-sdk/internal/_build?definitionId=4739 which now renders valid yaml. FYI @stliu @moarychan

@ghost
Copy link

ghost commented Sep 1, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 154265b into Azure:main Sep 1, 2022
@benbp benbp deleted the benbp/checkout-none-fix branch September 1, 2022 20:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants