Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress test scenarios object and multi-docker img support #3790

Merged
8 commits merged into from
Oct 20, 2022

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Jul 29, 2022

No description provided.

@ckairen ckairen added Do Not Merge Stress This issue is related to stress testing, part of our reliability pillar. labels Jul 29, 2022
@ckairen ckairen self-assigned this Jul 29, 2022
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ckairen ckairen force-pushed the albertcheng/stress-scenarios branch from a8af944 to ba24b2f Compare September 30, 2022 00:02
}
} else {
if ($pkg.Dockerfile) {
$dockerFilePath = Join-Path $pkg.Directory $pkg.Dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's print a deprecation warning here? Or do you think we should keep supporting chart.yaml docker configs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think we want so many config values just scattered around, let's just group them all in the matrix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're putting everything inside the matrix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case should we print a warning message here? The presence of it in chart.yaml won't fail anything otherwise. I'm wondering how to handle migration and config rot.

Copy link
Member Author

@ckairen ckairen Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been done here

$dockerPath = Join-Path $pkg.Directory $_.image;
[System.IO.Path]::GetFullPath($dockerPath) -eq
$dockerFilePath }).ForEach({$_.imageTag = $imageTag})
$genVal | ConvertTo-Yaml | Out-File -FilePath $genValFile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConvertTo-Yaml does not have ordered as parameter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckairen Did you figure out the issue with randomized matrix outputs? When you were doing the demo it looked like the output order was getting messed up from what I would expect based on the input.

Copy link
Member Author

@ckairen ckairen Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the issue is with this line because convertFrom-Json doesn't have ordered hashtable. It's only in powershell 7.3, which is in preview here's the link

@ckairen ckairen force-pushed the albertcheng/stress-scenarios branch from 3139d4f to e85b8bc Compare October 19, 2022 18:14
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ckairen
Copy link
Member Author

ckairen commented Oct 19, 2022

/check-enforcer override

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ckairen ckairen force-pushed the albertcheng/stress-scenarios branch from fc1d2a5 to 05b47d2 Compare October 20, 2022 21:24
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ckairen ckairen force-pushed the albertcheng/stress-scenarios branch from 0835548 to efbbaba Compare October 20, 2022 22:20
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ckairen
Copy link
Member Author

ckairen commented Oct 20, 2022

/check-enforcer override

@ghost
Copy link

ghost commented Oct 20, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e23e3d3 into main Oct 20, 2022
@ghost ghost deleted the albertcheng/stress-scenarios branch October 20, 2022 23:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Stress This issue is related to stress testing, part of our reliability pillar.
Projects
None yet
4 participants