-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stress test scenarios object and multi-docker img support #3790
Conversation
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
tools/stress-cluster/chaos/examples/network-stress-example/templates/testjob.yaml
Outdated
Show resolved
Hide resolved
a8af944
to
ba24b2f
Compare
} | ||
} else { | ||
if ($pkg.Dockerfile) { | ||
$dockerFilePath = Join-Path $pkg.Directory $pkg.Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's print a deprecation warning here? Or do you think we should keep supporting chart.yaml docker configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I don't think we want so many config values just scattered around, let's just group them all in the matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we're putting everything inside the matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case should we print a warning message here? The presence of it in chart.yaml won't fail anything otherwise. I'm wondering how to handle migration and config rot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been done here
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
Outdated
Show resolved
Hide resolved
$dockerPath = Join-Path $pkg.Directory $_.image; | ||
[System.IO.Path]::GetFullPath($dockerPath) -eq | ||
$dockerFilePath }).ForEach({$_.imageTag = $imageTag}) | ||
$genVal | ConvertTo-Yaml | Out-File -FilePath $genValFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConvertTo-Yaml does not have ordered as parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckairen Did you figure out the issue with randomized matrix outputs? When you were doing the demo it looked like the output order was getting messed up from what I would expect based on the input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, the issue is with this line because convertFrom-Json doesn't have ordered hashtable. It's only in powershell 7.3, which is in preview here's the link
tools/stress-cluster/cluster/kubernetes/stress-test-addons/templates/_util.tpl
Outdated
Show resolved
Hide resolved
tools/stress-cluster/cluster/kubernetes/stress-test-addons/templates/_util.tpl
Outdated
Show resolved
Hide resolved
3139d4f
to
e85b8bc
Compare
The following pipelines have been queued for testing: |
/check-enforcer override |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
fc1d2a5
to
05b47d2
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
0835548
to
efbbaba
Compare
The following pipelines have been queued for testing: |
/check-enforcer override |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
No description provided.