[Test-Proxy] Enforce Http 1.1 only #3216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On bothgo 1.17
andgo 1.18
we generate some wonky headers.:authority
:method
It is an artifact of the client, as per my understanding these aren't actually used by the service. Correct me if I'm wrong @seankane-msftIn the past, we were actually silently omitting them, but we got explicit with this PR.This PR brings it back to excluding them by default.Kestrel by default listens for both
http/1.1
andhttp/2
communication. The issue is that because we were allowing both, thego
clients don't know which to select. This is why we are seemingly randomly getting:authority
and:method
headers. The go client thinks it's talking http/2!By disallowing test-proxy from listening on http/2, we don't get those wonky headers sent anymore. The go client selects the correct protocol based on what our server tells it.