-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort by service name first #3160
Conversation
The following pipelines have been queued for testing: |
@@ -126,7 +126,7 @@ function GenerateDocfxTocContent([Hashtable]$tocContent, [String]$lang, [String] | |||
New-Item -Path $YmlPath -Name "toc.yml" -Force | |||
$visitedService = @{} | |||
# Sort and display toc service name by alphabetical order, and then sort artifact by order. | |||
$sortedToc = $tocContent.Values | Sort-Object NewIndex, TypeIndex, ServiceName, DisplayName, Artifact | |||
$sortedToc = $tocContent.Values | Sort-Object ServiceName, NewIndex, TypeIndex, DisplayName, Artifact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only used by the ToC? Where does the sorting for the package list on a given page happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our workflow is like,
Loop package in the defined order:
If we first meet the service,
- Create {service}.md and put the package info into toc.yml
- Then put the service entry into toc.yml.
If the service visited before, - Add content to {service}.md
So we have to sort the service to have service sorted in toc.yml first, then in each {service}.md we sort by track 2, client type and display name.
…fix_service_order
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixed the toc.yml order by sorting service name first.
After the fix.