Move Set-StrictMode to run after PSModule-Helpers.ps1 operations #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
sima-zhu,
weshaggard and
benbp
as code owners
|
The following pipelines have been queued for testing: |
This was referenced Feb 24, 2022
benbp
approved these changes
Feb 24, 2022
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
weshaggard
reviewed
Mar 11, 2022
| @@ -38,12 +38,13 @@ param( | |||
| [Parameter(Mandatory = $true)] | |||
| [string] $OutputLocation | |||
| ) | |||
| Set-StrictMode -Version 3 | |||
| . $PSScriptRoot/common.ps1 | |||
| . $PSScriptRoot/Helpers/PSModule-Helpers.ps1 | |||
There was a problem hiding this comment.
We should eventually fix the strict mode issues for this script instead of working around it.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Set-StrictMode to run after PSModule-Helpers.ps1 operations which violate strict mode and cause a falure as in https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1389880&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=61cf404c-fb38-582c-ffd7-16eb9e7ec7ac&l=97
Successful run after moving Set-StrictMode -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1390051&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=61cf404c-fb38-582c-ffd7-16eb9e7ec7ac
@benbp -- PTAL