Fill ms.author metadata for docs. #2608
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
sima-zhu
force-pushed
the
metadata_msalias
branch
from
e5ffdac to
1adfb41
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -94,15 +107,17 @@ function GetAdjustedReadmeContent($ReadmeContent, $PackageInfo, $PackageMetadata | |||
| } | |||
|
|
|||
| # Get the first code owners of the package. | |||
| $author = "ramya-rao-a" | |||
| $msauthor = "ramyar" | |||
There was a problem hiding this comment.
I assume you want to remove this initialization as well now.
| $author = "ramya-rao-a" | ||
| $msauthor = "ramyar" | ||
| } | ||
| $msauthor = GetMsAliasFromGithub -TenantId $TenantId -ClientId $ClientId -ClientSecret $ClientSecret -GithubUser $author |
There was a problem hiding this comment.
Should this entire block be in an else block? We don't need to translate the default case.
|
The following pipelines have been queued for testing: |
sima-zhu
force-pushed
the
metadata_msalias
branch
from
9a6fd46 to
1ef1d90
Compare
|
The following pipelines have been queued for testing: |
|
The strict mode failed the group id checking. Will have the fix in another PR |
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
The PR is filling the
ms.authormetadata for Doc.Ms.We use opensource aad app to call the opensource rest API.
Will test later in pipeline.
Pipeline with serects:https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1328164&view=results
Pre-requisites:
Have$(TenantId)/$ (ClientId)/$(ClientSecret) setup in vairable groups.