Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skip.SetTestPipelineVersion #1982

Merged
1 commit merged into from
Sep 8, 2021
Merged

Add Skip.SetTestPipelineVersion #1982

1 commit merged into from
Sep 8, 2021

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Sep 4, 2021 •
edited
Loading

Add Skip.SetTestPipelineVersion to allow overiding the SetTestPipelineVersion step for template pipelines.
Resolves #1664

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner September 4, 2021 01:40
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Sep 7, 2021
View reviewed changes
eng/common/pipelines/templates/steps/set-test-pipeline-version.yml Outdated
@@ -4,7 +4,7 @@ parameters:
TestPipeline: false

steps:
- ${{if eq(parameters.TestPipeline, 'true')}}:
- ${{if and(eq(parameters.TestPipeline, 'true'), ne(variables['Skip.SetTestPipelineVersion'], 'true')) }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this works? I cannot remember for sure but I don't know if queue time variables can be used in template conditions. I believe that is why we had to make them all runtime conditions in our release stages.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Sep 8, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Sep 8, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 91a70bc into Azure:main Sep 8, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@benbp benbp benbp approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable queue-time override of set-test-pipeline-version.yml
4 participants
@chidozieononiwu @azure-sdk @benbp @weshaggard