Add caching support to verify-links #1562
Conversation
|
The following pipelines have been queued for testing: |
|
No issues with this code. But I've been wondering whether we can have a more pluggable approach to these kinds of checks. Instead of plugging them into the pipelines themselves, we create a separate pipeline that runs the integrations indirectly. The rules for triggering the pipeline would be:
I think this file matching/commit history aware system could also be used for kinds of validations that we want to run as well. |
|
I assume you are talking about the github.io link checker. I've generally when with scheduled builds for these type of type of things as that is the best option we have short of writing our own scheduler/triggering mechanism. I know we have skirted around that issue for a while and I'm not sure this is enough of a reason to push us over the edge. That said if you want to file an issue on the backlog to track that I'm not opposed to the idea we just need to figure out how we would integrate it. |
weshaggard
force-pushed
the
CachingSupport
branch
from
be1bd3c to
39c7db1
Compare
|
The following pipelines have been queued for testing: |
- Update link checking pipeline to enable caching - Add loading cache file from a http endpoint - Add retry logic when hitting 429 Fix verify link renaming scenarios - Correctly error if link format is incorrect - Handle case where the replace regex is not passed - Improve the error logging so it is easier to identify the broken links
weshaggard
force-pushed
the
CachingSupport
branch
from
39c7db1 to
a7cf39a
Compare
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Fixes most of Azure/azure-sdk#2403
Fixes #1439