Ensure bypass conditional template gets run for 1es ubuntu image #1327
Conversation
|
/azp run java - formrecognizer - tests |
|
No pipelines are associated with this pull request. |
|
/check-enforcer evaluate |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The following pipelines have been queued for testing: |
| eq(variables['OSVmImage'], 'ubuntu-18.04'), | ||
| or( | ||
| eq(variables['OSVmImage'], 'ubuntu-18.04'), | ||
| eq(variables['OSVmImage'], 'MMSUbuntu18.04') |
There was a problem hiding this comment.
@mitchdenny do we have this set for all the pipelines now? OR will this still be an issue for some that don't have an OSVmImage set yet?
There was a problem hiding this comment.
I think if this was working before, there's no reason to think it will break now with the addition of an extra variable check. If the variable doesn't exist it will just evaluate to false.
There was a problem hiding this comment.
We still have some pipelines using ubuntu-18.04, specifically legs within the release side of the pipelines. So having it cover both scenarios is useful for now. And possibly going to be useful in the future when we start using Ubuntu 20.04 etc.
There was a problem hiding this comment.
I was fine with covering both. My question was more around did we update all the new pipelines with the new name, I know there were some where the OSVmImage name was empty and I'm not sure if you updated all those yet or not.
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This fixes an issue where the DNS bypass workaround was not getting run for the new 1es pool ubuntu images.
FYI @mitchdenny @alzimmermsft @samvaity