Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alpha and azure pipeline build version formats for SemVer parsing and sorting #1273

Merged
5 commits merged into from
Dec 12, 2020
Merged

Support alpha and azure pipeline build version formats for SemVer parsing and sorting #1273

5 commits merged into from
Dec 12, 2020

Conversation

benbp
Copy link
Member

@benbp benbp commented Dec 10, 2020

This PR updates the semver tooling to support our dev feed formats like:

5.3.0-alpha.20200928.3
# Python
2.0.0a20201208001

Supporting this format will enable us to sort release feeds that contain alpha releases, primarily so we can target smoke tests against the latest nightly and/or preview release, where applicable. Currently the smoke tests (at least for .net) have a bug where they are testing against very old dev releases, since they just pick the last item in the API response.

@benbp benbp requested a review from a team as a code owner December 10, 2020 22:18
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Dec 11, 2020

@weshaggard support added for optional zero-padding in non-python build versions. Updated the sorting and toString to handle [string]BuildNumber.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but otherwise looks good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Dec 12, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit cd67d61 into Azure:master Dec 12, 2020
@benbp benbp deleted the benbp/semver-alpha branch December 12, 2020 00:52
@benbp benbp restored the benbp/semver-alpha branch December 18, 2020 01:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants