-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve git longpath error when applying documentation updates #1270
Conversation
The following pipelines have been queued for testing: |
@@ -21,6 +21,15 @@ parameters: | |||
CloseAfterOpenForTesting: false | |||
|
|||
steps: | |||
- pwsh: | | |||
if ($IsWindows) { | |||
REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem /f /v LongPathsEnabled /t REG_DWORD /d 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of manually enabling long path on windows as it is pretty unreliable for general usage. Is there any way to fix the paths such that we don't hit the long file paths? If not then is there a way to make this template only run on non-windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't run on developer workstations so I think the blast radius of this change is contained. Enabling this flag in Windows is probably less painful then having someone stand up a Linux machine if they need to debug/test manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly this. The reason I'm submitting this PR is to make certain that nobody hits it in the future. One possible solution definitely would be to swap the Java build phase to use ubuntu
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this as a stop gap. Do we know if there is anyway to stop the long path files from being created to begin with?
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Like the errors seen in this release