Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to smoke-test before doc publishing error gets fixed. #1222

Merged
1 commit merged into from
Nov 20, 2020

Conversation

sima-zhu
Copy link
Contributor

No description provided.

@sima-zhu sima-zhu requested a review from a team as a code owner November 19, 2020 22:27
@sima-zhu sima-zhu requested review from weshaggard and scbedd and removed request for a team November 19, 2020 22:27
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Additional context for anyone reading this PR: The issue isn't the submission of PRs to master. The issue is that when CI writes to master (instead of smoke-test), there is a publishing failure that wasn't resolvable with information we had. Manual queues of publishing of that same commit worked just fine.

@sima-zhu sima-zhu added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Nov 19, 2020
@sima-zhu sima-zhu self-assigned this Nov 19, 2020
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

Change looks good but I'm curious what our plan is to get these changes into master now? I thought we were trying to eliminate the smoke-test branch.

@sima-zhu
Copy link
Contributor Author

Change looks good but I'm curious what our plan is to get these changes into master now? I thought we were trying to eliminate the smoke-test branch.

@scbedd has explained in comments as well.
OPS builds triggered by master commits hide the real issue behind of SSO issue. We are not able to get the real issue before merge to live. We have a ticket filed to the docs team to resolve the issue first before we target to master.

@scbedd
Copy link
Member

scbedd commented Nov 20, 2020

Change looks good but I'm curious what our plan is to get these changes into master now? I thought we were trying to eliminate the smoke-test branch.

The plan is definitely to eliminate the smoke-test branch. We just haven't swapped yet because when CI writes to master, we get a weird SSO Auth error in the build. We have an issue filed against the docs dev team, and last I heard they were actually looking at it.

ghost pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 20, 2020
@ghost
Copy link

ghost commented Nov 20, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit edfa287 into Azure:master Nov 20, 2020
@sima-zhu sima-zhu deleted the switch_master branch November 20, 2020 02:38
sima-zhu added a commit that referenced this pull request Dec 9, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants