Change live test resource DeleteAfterHours tag to 8 hours #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
requested review from
danieljurek,
heaths and
weshaggard
as code owners
|
The following pipelines have been queued for testing: |
|
Actually, 24hrs was picked because the script only ran every 24hrs. Does the script run more often now? |
heaths
approved these changes
Nov 12, 2020
I will have to change the pipeline schedule too. |
This was referenced Nov 12, 2020
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
benbp
added a commit
that referenced
this pull request
Dec 1, 2020
This reduces the default from 24 hours to 8 hours. The cleanup pipeline takes only a few minutes so this shouldn't add any load: https://dev.azure.com/azure-sdk/internal/_build?definitionId=1357&_a=summary The original 24 value was arbitrary. I'm picking 8 because it's the lowest value that's safely longer than any of our existing live tests (currently storage takes 6 hours). Related to #754
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
…tes and no UTF-8 BOM. (Azure#1199) * Add script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM. * Update script to include all files in the repo. * Update script and make sure it only runs once. * Address PR feedback, update script. * Skip the tools directory for now.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the default from 24 hours to 8 hours. The cleanup pipeline takes only a few minutes so this shouldn't add any load: https://dev.azure.com/azure-sdk/internal/_build?definitionId=1357&_a=summary
The original 24 value was arbitrary. I'm picking 8 because it's the lowest value that's safely longer than any of our existing live tests (currently storage takes 6 hours).
Related to #754