Switch the content from array to string. #1103
Conversation
sima-zhu
requested review from
weshaggard and
praveenkuttappan
and removed request for
a team
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
| @@ -205,7 +205,7 @@ function Upload-Blobs | |||
| if ($ReleaseTag) { | |||
| foreach ($htmlFile in (Get-ChildItem $DocDir -include *.html -r)) | |||
| { | |||
| $fileContent = Get-Content -Path $htmlFile | |||
| $fileContent = Get-Content -Path $htmlFile -Raw | |||
| $updatedFileContent = $fileContent -replace $RepoReplaceRegex, "`${1}$ReleaseTag" | |||
| if ($updatedFileContent -ne $fileContent) { | |||
| Set-Content -Path $htmlFile -Value $updatedFileContent | |||
There was a problem hiding this comment.
@sima-zhu since you are now using -Raw have you verified that the Set-Content works correctly? I think you will need to now pass the "-NoNewLine" option to it as well otherwise it will add a new line at the end of the file.
There was a problem hiding this comment.
Did not verify newline, but double check with the all release tag works just fine. Will do more check here and submit a new PR if it is a miss.
There was a problem hiding this comment.
I just tested it locally, it actually add new line in the scripts. Thanks for spotting the issue. Will submit another PR.
This is a follow up PR (#1103) which introduced extra new line at the end of the file. Local testing indicates we added new line at end. Checked the github io, and it does not bring too many differences. E.g. After PR, https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.22/index.html Before PR, https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.20/index.html
Fixed the issue: Azure/azure-sdk-for-js#11827 JS pipeline running super slow on array object of `Get-Content`. Tested using -Raw, replacement works correctly and the entire process speeds up.
This is a follow up PR (#1103) which introduced extra new line at the end of the file. Local testing indicates we added new line at end. Checked the github io, and it does not bring too many differences. E.g. After PR, https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.22/index.html Before PR, https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.20/index.html
Fixed the issue: Azure/azure-sdk-for-js#11827
JS pipeline running super slow on array object of
Get-Content.Tested using -Raw, replacement works correctly and the entire process speeds up.