New logo for APIView tool #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
pakrym and
JoshLove-msft
and removed request for
pakrym
|
It's hard to tell if the image dimensions are good. I can make the text or the logo larger if the dimensions aren't right. Can you put this onto staging to check? |
|
what about favicon? Also, logo-text looks a bit blurry compared to other text on the page. Worth adding just the logo image and keeping text as text? |
|
I have updated favicon and made change to logo as per suggestion from @pakrym to add only image and retain text.
|
|
Not sure I all the browsers support PNG-renamed-into-ico as a favicon. |
pakrym
approved these changes
Sep 23, 2020
I will check on few browsers: firefox, chrome, edge, edge preview and probably safari too. |
|
@pakrym I have generated favicon from png and updated it. |
|
Ship it! :) |
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
* Update az_span_scan_util logic and behavior. * Update predicate used by scan util to work on single bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new logo for APIView.dev in login and home screen. @JonathanGiles has shared this logo. Please let me know your feedback.
Home screen
Login Screen