Changelog Tool Bumps Stable Version for Preview API with Latest Modular CodeGen #8522
Closed
Assignees
Labels
Comments
|
The bug is introduced by new codegen pr. The way to define default api version is changed. e.g. new api-version at client level is defined here tasks:
|
wanlwanl
changed the title
wanlwanl
changed the title
wanlwanl
changed the title
wanlwanl
changed the title
|
PR to fix: #8671 |
wanlwanl
added a commit
that referenced
this issue
Jul 22, 2024
# Issue #8522 # Problem The bug is introduced by new codegen [pr](Azure/autorest.typescript@b0853b2). The way to define default api version is changed. extracting the api version should also consider version of codegen. e.g. new api-version at client level is defined [here](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/mongocluster/arm-mongocluster/src/rest/documentDBClient.ts#L23) while old one is: - [here](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/face/ai-vision-face-rest/src/faceClient.ts#L26) - [another](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/openai/openai-rest/src/openAIClient.ts#L22) # Solution 1. try to detect in new client, return api-version if found 2. fallback to detect old client, return whatever found
WhitShake
pushed a commit
to WhitShake/azure-sdk-tools
that referenced
this issue
Jul 24, 2024
# Issue Azure#8522 # Problem The bug is introduced by new codegen [pr](Azure/autorest.typescript@b0853b2). The way to define default api version is changed. extracting the api version should also consider version of codegen. e.g. new api-version at client level is defined [here](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/mongocluster/arm-mongocluster/src/rest/documentDBClient.ts#L23) while old one is: - [here](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/face/ai-vision-face-rest/src/faceClient.ts#L26) - [another](https://github.com/Azure/azure-sdk-for-js/blob/06716722818f5838cc10a9e5644b7ba9f32089d5/sdk/openai/openai-rest/src/openAIClient.ts#L22) # Solution 1. try to detect in new client, return api-version if found 2. fallback to detect old client, return whatever found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this pr is generated with modular
Azure/azure-sdk-for-js#30102
and the generated version is 1.0.0-beta.1
but after usiing changelog tool, it becomes 1.0.0
The text was updated successfully, but these errors were encountered: