Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the breaking detection between HLC and modular classical layer #8305

Closed
Tracked by #8046
MaryGao opened this issue May 21, 2024 · 1 comment
Closed
Tracked by #8046
Assignees
Labels

Comments

@MaryGao
Copy link
Member

MaryGao commented May 21, 2024

failed to generate the changelog between HLC and Modular:
image

it's a issue in https://github.com/Azure/azure-sdk-tools/blob/main/tools/js-sdk-release-tools/src/hlc/utils/automaticGenerateChangeLogAndBumpVersion.ts#L28
where caused this error.
From HLC package, we have src/models/parameters.ts to generate the api version and let the tool read this to check whether the release is a stable release. but in modular, src/models/parameters.ts doesn't exist.

steps to repro:

  1. checkout try to test cases for networkanalytics with modular generation azure-sdk-for-js#29770
  2. in JS sdk repo root path, run changelog-tool sdk/networkanalytics/arm-networkanalytics
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 21, 2024
@MaryGao MaryGao changed the title Support the breaking detection between HLC and modular Support the breaking detection between HLC and modular classical layer May 22, 2024
@MaryGao MaryGao added the P0 label May 22, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 22, 2024
@MaryGao
Copy link
Member Author

MaryGao commented May 23, 2024

EngSys and Automation Categorization

  • Parity with existing tooling in Track2
  • New functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants