Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET branding is wrong in PR bot #6924

Open
heaths opened this issue Sep 8, 2023 · 2 comments
Open

.NET branding is wrong in PR bot #6924

heaths opened this issue Sep 8, 2023 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@heaths
Copy link
Member

heaths commented Sep 8, 2023

Please use proper branding at least for first-party applications: ".Net" -> ".NET":

image
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 8, 2023
heaths added a commit to heaths/azure-sdk-tools that referenced this issue Sep 8, 2023
Was an attempt to try fixing issue Azure#6924 but it seems that code may live elsewhere. Figured I might as well update public-facing first-party branding in this repo while I was in here.
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 11, 2023
@kurtzeborn
Copy link
Member

This is messaging added by the pipeline bot I believe.

@kurtzeborn kurtzeborn moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Sep 11, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Sep 22, 2023
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Sep 22, 2023

The language string is in APIViewInfo. See here:

let apiViews : APIViewInfo[] = (context.pr.apiViewsSDK ?? []).concat(context.pr.apiViewsSpecs ?? []);
(...)
const commentBody = generateApiViewComment({ title: apiViewCommentGroup.title, apiViews });

language is set in addEventToApiViewsIfNotAlreadyPresent:

apiViews.push({
  language: event.language,
  packageName: event.packageName,
  apiViewLink: event.apiViewLink,
  errorMessage: event.errorMessage,
});

where event: ApiViewEvent.

It comes from here

event.status === "apiview"

which comes e.g. from GenerateApiView task:

{"level":"info","message":"EventHubProducer.send: FQN/eventHubName: openapi-platform-events.servicebus.windows.net/pipeline-events, events: {"status":"apiview","env":"prod","source":"github","pipelineJobStageName":"AzureRestApiSpecsPipeline","unifiedPipelineTaskKey":"ApiView","unifiedPipelineBuildId":"43db1861-7254-4efe-92ba-877fc5ba8b98","apiViewLink":"https://apiview.dev/Assemblies/Review/4a9364b6707641cb9062ee42cc79dc56","language":"Swagger","packageName":"Microsoft.DigitalTwins"}"}

There is also TypeSpecAPIView but I am not sure if it means there are more strings to fix.

@chidozieononiwu @praveenkuttappan I am assigning this to you as it looks to me the string originates from within API View.

heaths added a commit to heaths/azure-sdk-tools that referenced this issue Sep 25, 2023
Was an attempt to try fixing issue Azure#6924 but it seems that code may live elsewhere. Figured I might as well update public-facing first-party branding in this repo while I was in here.
weshaggard pushed a commit that referenced this issue Sep 27, 2023
* Fix .NET branding in public docs

Was an attempt to try fixing issue #6924 but it seems that code may live elsewhere. Figured I might as well update public-facing first-party branding in this repo while I was in here.

* Update src/dotnet/APIView/APIViewWeb/CONTRIBUTING.md

Co-authored-by: Mariana Rios Flores <[email protected]>

* Resolve PR feedback

---------

Co-authored-by: Mariana Rios Flores <[email protected]>
@praveenkuttappan praveenkuttappan removed their assignment Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

5 participants