Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products with no action items in CLC are not available in the PowerApps solutions #6638

Closed
ladonnaq opened this issue Aug 1, 2023 · 8 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience

Comments

@ladonnaq
Copy link
Member

ladonnaq commented Aug 1, 2023

The Cosmos Postgres team is working on releasing SDKs for a post-GA product. The product completed GA in 2019, so long before any of the process or Engagement tools/apps were around.

We used the retired product and onboarded it so that way we could proceed with creating a release plan. This was to unblock the service team. However, this is not accurate as they are not doing work on a retired product.

Note: Cloud Lifecycle was not launched until April 2022. Any service that had products that had not reached GA had CLC records created and action items were automatically completed. For services with products that had completed GA, any CLC record will not be useful as most do not have any CLC action items. They were signed off using the old form and CLC records were created without action items for most.

@maririos maririos added the Central-EngSys This issue is owned by the Engineering System team. label Aug 2, 2023
@maririos maririos moved this from New to Backlog in Engagement Experience Aug 2, 2023
@maririos maririos self-assigned this Aug 3, 2023
@maririos maririos moved this from Backlog to In Progress in Engagement Experience Aug 4, 2023
@JonathanCrd JonathanCrd self-assigned this Aug 7, 2023
@JonathanCrd
Copy link
Member

I took a look at this and found that the product Hyperscale (Citus) is not part of the Product Profiles table in PROD, which means that is it being ignored by the cloud flow that synchronize the products with Service Tree and the other one for the Service-Product mapping table.

The reason this is happening is because Hyperscale (Citus) does not have something called 360ExpandedActionItem. We don't know what these Actions Items are about or how to check if in fact this product is missing them. I also wonder why the flow is filtering out these products in the first place. Anyway, I will keep looking at this and add a comment in this issue if I find more information about it.

In the meantime, @ladonnaq we have these questions:

  • Do you know what these Actions Items are? Could you give us more context about it?
  • Can you create Action Items for this product in service tree, so it doesn't get filtered out by our flow?

@maririos maririos removed their assignment Aug 8, 2023
@JonathanCrd JonathanCrd moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Aug 8, 2023
@JonathanCrd JonathanCrd moved this from In Progress to Blocked in Engagement Experience Aug 9, 2023
@JonathanCrd JonathanCrd removed their assignment Aug 22, 2023
@maririos
Copy link
Member

maririos commented Sep 5, 2023

ping @ladonnaq in case you can help us here

@ladonnaq
Copy link
Member Author

I took a look at this and found that the product Hyperscale (Citus) is not part of the Product Profiles table in PROD, which means that is it being ignored by the cloud flow that synchronize the products with Service Tree and the other one for the Service-Product mapping table.

The reason this is happening is because Hyperscale (Citus) does not have something called 360ExpandedActionItem. We don't know what these Actions Items are about or how to check if in fact this product is missing them. I also wonder why the flow is filtering out these products in the first place. Anyway, I will keep looking at this and add a comment in this issue if I find more information about it.

In the meantime, @ladonnaq we have these questions:

  • Do you know what these Actions Items are? Could you give us more context about it? I have no clue but I can ask. I will send an email to the S360 and CLC team to find out.
  • Can you create Action Items for this product in service tree, so it doesn't get filtered out by our flow? The action items in CLC should be our launch criteria. I will ask the S360/CLC team and let you know.

@maririos
Copy link
Member

This is happening to another service-product (Azure Batch - Batch) :

I was looking more into it and found issue #5228 and look at Wei's comment:

There are no corresponding action items, while we sync products from CLC, if action items are missing, some fields will be empty, so we escape these products.
That's why they do not exist in Dev and Prod, which is correct.

For example:

This means 2 things:

  1. Our tooling depends on Service Tree and on CLC entries
  2. Products need to have information entered in CLC

The question now is, why some products don't have that? @ladonnaq could you help us understand this? what is CLC used for at Microsoft?

@maririos maririos changed the title **BUG** Service team completing post-GA work and the product is not showing up in drop-down list to onboard Products with no action items in CLC are not available in the PowerApps solutions Nov 29, 2023
@ladonnaq
Copy link
Member Author

ladonnaq commented Dec 4, 2023

This is happening to another service-product (Azure Batch - Batch) :

I was looking more into it and found issue #5228 and look at Wei's comment:

There are no corresponding action items, while we sync products from CLC, if action items are missing, some fields will be empty, so we escape these products.
That's why they do not exist in Dev and Prod, which is correct.

For example:

This means 2 things:

  1. Our tooling depends on Service Tree and on CLC entries
  2. Products need to have information entered in CLC

The question now is, why some products don't have that? @ladonnaq could you help us understand this? what is CLC used for at Microsoft?

Background: CLC was launched in April 2022. The CLC and APEX team spent most of 2022 onboarding teams to use CLC. Through automation, CLC team migrated existing products, but I do not know if it was ALL products in service tree. Because of this there could be products in CLC that do not have action items. The action items showing or not showing is controlled by policies related to the S360 action item (APEX launch criteria).
Initially the Shanghai team was using the CLC/S360 metadata to get the product mapping but products were missing (b/c they did not have CLC records). When the issue was fixed, I thought the logic was changed to use service tree data to determine the product list for each service in the release planner. Service tree is the source of truth for service product mapping and lifecycle metadata (launch dates, current lifecycle, ...). CLC is using service tree metadata for the lifecycle dates, etc. So if the service tree metadata is wrong, then CLC lifecycle dates are wrong.

  1. What is the effort to redesign and implement? Service-product mapping should be determined using service tree not CLC/S360 data. It could be that Wei had this dependency to "qualify" the product list, which would make sense for APEX scenarios but not for non-APEX scenarios. So we may need to redesign to support non-APEX scenarios. Azure Batch, Azure Support, and Cosmos have all ran into this issue and the work they were doing was all non-APEX. Azure Batch and Azure Support could not use the release planner.
  2. Because CLC was not launched until April 2022, there will be gaps especially with older services/products. The older products that were migrated to CLC have inconsisent data in regards to the CLC action items. Some show action items and they were automatically marked complete, some show no action items at all, etc.

@maririos
Copy link
Member

maririos commented Dec 4, 2023

@ladonnaq thank you so much for this context!!
To make sure I understood your recommendation, Eng team should look into

Service-product mapping should be determined using service tree not CLC/S360 data

Basically, remove the CLC dependency so teams that are non-APEX can use our tooling.

@maririos maririos moved this from Blocked to Backlog in Engagement Experience Dec 4, 2023
@maririos
Copy link
Member

maririos commented Dec 4, 2023

Moving out of blocked as it looks like we know the problem and it is on Eng to figure out how to remove the CLC dependency

@ladonnaq
Copy link
Member Author

FYI - Hit this issue with another team last week. This will be important because of TypeSpec so need to unblock the teams when we do so (January timeframe). Thanks!

@maririos maririos moved this from Backlog to In Progress in Engagement Experience Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants