Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Breaking changes PR check does not check against latest GA version #6567

Open
mikekistler opened this issue Jul 24, 2023 · 1 comment
Open

[Breaking Change] Breaking changes PR check does not check against latest GA version #6567

mikekistler opened this issue Jul 24, 2023 · 1 comment
Assignees
@konrad-jamrozik
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

mikekistler commented Jul 24, 2023 •
edited by konrad-jamrozik
Loading

The Breaking Change(Cross-Version) check in PR 13404 checks for breaking changes against the earlier preview (2023-01-01-preview) but not against the latest GA (2023-06-01).

image

This issue belongs to a set of related (and possibly at least partially duplicate) issues:
@mikekistler mikekistler added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Jul 24, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 24, 2023
@konrad-jamrozik konrad-jamrozik changed the title Breaking changes PR check does not check against latest GA version [Breaking Change] Breaking changes PR check does not check against latest GA version Jul 25, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jul 25, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jul 25, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Jul 25, 2023
@josefree
Copy link
Member

Another case can be referred for this issue Azure/azure-rest-api-specs#23327

@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Jul 28, 2023
This was referenced Jul 7, 2023
Open
Closed
Open
@konrad-jamrozik konrad-jamrozik added the Breaking Changes Improvements to Breaking Changes tooling label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🚢🎉
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konrad-jamrozik @josefree @mikekistler